Conversation
imobachgs
force-pushed
the
force-timezone
branch
from
958ef2b to
bc6cf82
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
|
After some tests, the real problem seems to be that YaST is overwriting the localtime. I need to rethink the solution. |
imobachgs
force-pushed
the
force-timezone
branch
2 times, most recently
from
c6bbbf4 to
204d48f
Compare
imobachgs
force-pushed
the
force-timezone
branch
from
204d48f to
6ebe3ba
Compare
dgdavid
approved these changes
Dec 3, 2023
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
Reading the code looks good. So, if you've tested that it works... Just go ahead!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
YaST is rewriting the timezone settings. See #903.
Solution
InstFunctionsmodule to avoid loading some code when asking whether the second stage will be executed (no second stage in Agama). This code ended up writing the timezone with the wrong value.Testing